remove more allocations #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did this to get a sense for how much `jiff::fmt` depends on `alloc`. It actually looks pretty good. Most uses of `alloc` are just for convenience `String` APIs. The one hiccup is `strtime` where it uses `String` for IANA time zone names and time zone abbreviations. I think I can use a small fixed size array for time zone abbreviations, but that might be harder to get away with for IANA names. With that said, I'm not planning to really support IANA time zones in core-only mode, so we can probably just `cfg` ourselves out of that problem for the most part.
This removes yet another needless but harmless allocation in pursuit of progress on #168. In this case, returning a `&str` is part of the public API when a time zone is a fixed offset, so we do need to store the offset as a string somewhere. Thankfully, it's pretty small (smaller than a `Box<str>`) and there's a predictable maximum length on the string. So it's not a big deal to just generate the string on the stack and store it in the `TimeZone` for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work from #179 to make progress on #168.