Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tz: fix termux compilation on Android #201

Merged
merged 1 commit into from
Jan 13, 2025
Merged

tz: fix termux compilation on Android #201

merged 1 commit into from
Jan 13, 2025

Conversation

BurntSushi
Copy link
Owner

I guess some platforms use *const u8 for C strings while most
seemingly use *const i8. So insert a bunch of .cast() calls where
appropriate.

Ref #140

Fixes #200

@BurntSushi BurntSushi mentioned this pull request Jan 12, 2025
Closed
@dead10ck
Copy link

dead10ck commented Jan 12, 2025 •
edited
Loading

I checked this out locally and I can confirm it builds now! There are a few compiler warnings for unused code, but all but one test passes. Thank you!

@BurntSushi
tz: fix termux compilation on Android
a839244 
I guess some platforms use `*const u8` for C strings while most
seemingly use `*const i8`. And indeed, `CStr::as_ptr` returns a
`*const u8` or a `*const i8` depending on the platform. So do the right
thing here and use std's `c_char` alias.

Ref #140

Fixes #200
@BurntSushi BurntSushi merged commit 663607e into master Jan 13, 2025
20 checks passed
@BurntSushi BurntSushi deleted the ag/fix-termux branch January 13, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compilation failure on Android in termux shell
2 participants
@BurntSushi @dead10ck