-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CMake build #278
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 72.81% 71.22% -1.59%
==========================================
Files 18 18
Lines 982 966 -16
==========================================
- Hits 715 688 -27
- Misses 267 278 +11 ☔ View full report in Codecov by Sentry. |
I've decided not to add unit tests for |
aba377e
to
e77f59f
Compare
Should we remove support for the old build systems at the same time? It isn't strictly necessary for this PR but wouldn't it make things nicer for us? Bringing the old build systems to CMake might not take that much time now that we have a working example to use in main. |
@ccarouge if you are referring to the custom build via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, although I really don't know enough about the benchcab inner workings to give a detailed review.
b731a72
to
f698427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we are breaking the custom build script support but I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CABLE build system was transitioned from Makefile to CMake: see CABLE-LSM/CABLE#216, CABLE-LSM/CABLE#200. This change adds support for building CABLE via CMake in benchcab so that CABLE versions which branch from the HEAD of main can be tested. Closes #258
dd04dd4
to
8d41929
Compare
The CABLE build system was transitioned from Makefile to CMake: see CABLE-LSM/CABLE#216, CABLE-LSM/CABLE#200. This change adds support for building CABLE via CMake in benchcab so that CABLE versions which branch from the HEAD of main can be tested.
Closes #258