Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Polling for Cross Submission Validation #380

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix Polling for Cross Submission Validation #380

merged 2 commits into from
May 24, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 23, 2024 •
edited
Loading

Overview

This PR addresses broken Cross Submission validation polling in 3.0.0

Change Details (Specifics)

  • Add crossSubmissionStatus check before disabling Submission polling
  • Remove unnecessary manual getSubmission fetch now that polling is every 1s

Related Ticket(s)

N/A

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label May 23, 2024
@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone May 23, 2024
@amattu2 amattu2 changed the base branch from main to 3.0.0 May 23, 2024 14:35
@amattu2 amattu2 marked this pull request as ready for review May 24, 2024 14:55
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label May 24, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega May 24, 2024 14:55
@amattu2 amattu2 enabled auto-merge May 24, 2024 14:57
Alejandro-Vega
Alejandro-Vega approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will hold off on merging since there is an active discussion on this. Feel free to merge when you feel it is ready.

@amattu2 amattu2 merged commit 1718cc2 into 3.0.0 May 24, 2024
5 checks passed
@amattu2 amattu2 deleted the HOTFIX/cross-submission-polling branch May 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0 (PMVP-M1)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega