Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1095 Data Submission Upload update for "Metadata Only" Data Type #384

Merged
merged 8 commits into from
May 28, 2024
Merged

CRDCDH-1095 Data Submission Upload update for "Metadata Only" Data Type #384

merged 8 commits into from
May 28, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented May 24, 2024 •
edited
Loading

Overview

Updated Step 2 in the Data Submission data upload process to display text when Submission is "Metadata Only".

Change Details (Specifics)

  • Replaced Step 2 text and hid buttons when Submission is "Metadata Only"
  • Disabled "Validate Data Files" and "Both" when Submission is "Metadata Only". Although, this would never be enabled anyways since BE is blocking Data Files from ever being uploaded for this dataType.
  • The "Submit" button is enabled when all metadata passed validation in a "Metadata Only" dataType Submission.

Note

BE API's are not ready. Submit won't work, but the button will be enabled. Also, you can still upload Data Files to a 'Metadata Only' Submission via the CLI.

Related Ticket(s)

CRDCDH-1095

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label May 24, 2024
@Alejandro-Vega Alejandro-Vega added this to the 3.0.0 (PMVP-M1) milestone May 24, 2024
Base automatically changed from CRDCDH-1094 to 3.0.0 May 28, 2024 17:30
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review May 28, 2024 18:59
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 May 28, 2024 18:59
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label May 28, 2024
amattu2
amattu2 approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM.

@amattu2 amattu2 merged commit 0096be9 into 3.0.0 May 28, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1095 branch May 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0 (PMVP-M1)
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @amattu2