Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2268 Display Uploader CLI Version #619

Merged
merged 7 commits into from
Feb 10, 2025
Merged

CRDCDH-2268 Display Uploader CLI Version #619

merged 7 commits into from
Feb 10, 2025

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Feb 6, 2025

Overview

Added the latest Uploader CLI Version within the "Upload Data Files" section of a Data Submission, as well as within the Uploader CLI download dialog.

Note

Design is not finalized. Just used whatever was on Figma at the time. Will update in separate PR once design is ready.

Change Details (Specifics)

  • Added support for new env variable REACT_APP_UPLOADER_CLI_VERSION
  • Displayed Uploader CLI version within the "Upload Data Files" section of a Data Submission. Hidden if invalid/missing or submission does not include Data Files upload
  • The version in the Data Submission has a tooltip and if you click it will open the Uploader CLI Tool download dialog
  • Added Uploader CLI version within the Uploader CLI Tool download dialog. Hidden if invalid/missing

Related Ticket(s)

CRDCDH-2268 (Task)
CRDCDH-2274 (US)

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Feb 6, 2025
@Alejandro-Vega Alejandro-Vega added this to the 3.2.0 (PMVP-M3) milestone Feb 6, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13205302688

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 60.133%

Totals Coverage Status
Change from base Build 13181319649: 0.06%
Covered Lines: 4296
Relevant Lines: 6713

💛 - Coveralls

@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Feb 7, 2025
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review February 7, 2025 18:13
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging as-is, left an optional suggestion for the PR when we implement the final design.

@amattu2 amattu2 merged commit 5dc4987 into 3.2.0 Feb 10, 2025
7 checks passed
@amattu2 amattu2 deleted the CRDCDH-2268 branch February 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants