Skip to content

Commit

Permalink
Tooltip bug fixed (#1744)
Browse files Browse the repository at this point in the history
* 2 bugs fixed, will be double checking and testing to make sure everything is working

* still seems to be working
  • Loading branch information
alaapbharadwaj authored Aug 28, 2024
1 parent fd1b418 commit eb85c88
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ const SearchResultsListOptions = ({ disabled = false }: Props) => {
}, []);

return (
<ButtonActionMenu className={styles.option} outline icon={<Icon.SortArrow />} disabled={disabled}>
<ButtonActionMenu
className={styles.option}
ariaLabel="Sort by list"
outline
icon={<Icon.SortArrow />}
disabled={disabled}>
<>
<Button
type="button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import classNames from 'classnames';

type Props = {
label?: string;
ariaLabel?: string;
disabled?: boolean;
icon?: ReactNode;
outline?: boolean;
Expand All @@ -17,6 +18,7 @@ type Props = {
export const ButtonActionMenu = ({
label,
disabled,
ariaLabel,
icon,
outline,
className,
Expand Down Expand Up @@ -45,7 +47,7 @@ export const ButtonActionMenu = ({
return (
<div className={styles.actionMenu} ref={wrapperRef}>
<Button
aria-label="Sort by list"
aria-label={ariaLabel}
data-tooltip-position="top"
type="button"
onClick={() => setOpen(!open)}
Expand Down

0 comments on commit eb85c88

Please sign in to comment.