Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPaT Code Coverage #5

Merged
merged 3 commits into from
Mar 10, 2025
Merged

SPaT Code Coverage #5

merged 3 commits into from
Mar 10, 2025

Conversation

drewjj
Copy link
Collaborator

@drewjj drewjj commented Mar 7, 2025

This adds complete code coverage for SPaT.

Sample data was created through erlang and converted to XML and JSON with the asn1c scripts. Some tests directly target corner cases where natural ser/des does not cover.

image

@drewjj drewjj requested review from iyourshaw and Michael7371 March 7, 2025 00:56
Copy link

github-actions bot commented Mar 7, 2025

Overall Project 79.04%

There is no coverage information present for the Files changed

Copy link
Collaborator

@iyourshaw iyourshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please redo the bitstring test as noted.

Copy link

Overall Project 81.66% 🍏

There is no coverage information present for the Files changed

@iyourshaw iyourshaw self-requested a review March 10, 2025 17:52
Copy link
Collaborator

@iyourshaw iyourshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good

@iyourshaw iyourshaw merged commit 235292f into j2735-2024 Mar 10, 2025
1 check passed
@drewjj drewjj deleted the j2735-2024-spat branch March 12, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants