Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp Logging Reduction and Intersection API Auth Fix #168

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

jacob6838
Copy link
Collaborator

@jacob6838 jacob6838 commented Feb 19, 2025

PR Details

Description

This PR handles the following minor bug fixes:

  • reducing unnecessary logging
    • Removed REST api request/response logging - this is all available through the "network" tab of the chrome debug console
    • Removed extraneous debug logs, which do not provide meaningful debugging information
    • Vague console logs were updated with more specific information
    • Console logs exposing sensitive information were removed/updated
    • Elevated relevant messages to warnings/errors
    • Left in "Successfully deleted organization" as this may be useful. This is also available through the redux extension in the chrome debug console, but most users will not have this installed
  • removing unused kcFailure slice variable
  • Adding KEYCLOAK_CLIENT_ID to webapp .env.development
  • webapp STOMP websocket error handling was condensed
  • Reducing unnecessary error responses for intersection ID -1
  • Ignoring .env.local from webapp docker build

How Has This Been Tested?

This was tested locally, through docker and npm (webapp). All unit tests pass

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@jacob6838 jacob6838 requested a review from drewjj February 19, 2025 19:15
@jacob6838 jacob6838 requested a review from mwodahl February 19, 2025 19:17
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass and logging changes make sense to me! Runs locally as well.

Copy link
Collaborator

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and looks good when run locally! It's nice to have the console much less cluttered

Removing Duplicate Webapp Keycloak Auth Provider
@jacob6838 jacob6838 merged commit 57334b3 into develop Feb 27, 2025
8 checks passed
@jacob6838 jacob6838 deleted the intersection-api-auth-fixes branch February 27, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants