Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection Map UI Update #174

Open
wants to merge 9 commits into
base: Update/ui-theme
Choose a base branch
from

Conversation

mwodahl
Copy link
Collaborator

@mwodahl mwodahl commented Feb 27, 2025

PR Details

This PR updates the intersection map UI to match the following figma prototype: https://www.figma.com/proto/QG64ugNXpXMUk2vQ1wgPdZ/CV-Manager-Prototype-January-2025?page-id=2143%3A6061&node-id=2146-7749&viewport=-595%2C-659%2C0.22&t=A1CuORABoO0Qexzk-1&scaling=scale-down&content-scaling=fixed&starting-point-node-id=2146%3A6646

Description

This PR includes the following changes:

  • Updated the slider and control panel accordion to use a transparent background
  • Removed the Visual Settings panel from the control panel accordion and placed into separate component with floating action button
  • Updated map legend and information panel layouts and added floating action buttons
  • Added +/- buttons to control map zoom

How Has This Been Tested?

This was tested locally with docker compose and unit tests were verified to pass using npm. Please note that these changes were tested with the theme updates present in #172.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • [ X ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • [ X ] All existing tests pass.

@mwodahl mwodahl changed the base branch from develop to Update/ui-theme February 27, 2025 17:09
Comment on lines 509 to 510
<MapLegend />
<VisualSettings />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can override each other - can we have them toggle or add them to a dynamic grid? This includes the visual settings, information, and legend

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a toggle so that these no longer display over one another

setOpen(!open)
}}
>
<VpnKeyOutlined />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this as a legend icon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something more like this (from wyoroadinfo):
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use an icon similar to the one you suggested

right: 0,
width: open ? 600 : 50,
fontSize: '16px',
overflow: 'auto',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scrollbar should be for the contents, and leave the title at the top:
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to the other popup components as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the popup components to only scroll content

Copy link
Collaborator

@jacob6838 jacob6838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the icons don't use the theme colors, and are dark background with a black outline:
image
image

@jacob6838 jacob6838 requested a review from John-Wiens February 27, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants