-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved GP fitness to use NRMSE #300
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 97.01% 97.02% +0.01%
==========================================
Files 29 29
Lines 1842 1849 +7
==========================================
+ Hits 1787 1794 +7
Misses 55 55
Continue to review full report in Codecov by Sentry.
|
@jmafoster1 Thanks Michael, I'll put some time aside to review this this afternoon. |
causal_testing/estimation/genetic_programming_regression_fitter.py
Outdated
Show resolved
Hide resolved
causal_testing/estimation/genetic_programming_regression_fitter.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmafoster1 Some quick fixes - see comments above.
Thanks @f-allian, fixed them all |
GP fitness now uses NRMSE instead of just MSE, fixed a couple of other bugs, and removed a print statement.