Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved GP fitness to use NRMSE #300

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Improved GP fitness to use NRMSE #300

merged 13 commits into from
Jan 6, 2025

Conversation

jmafoster1
Copy link
Contributor

GP fitness now uses NRMSE instead of just MSE, fixed a couple of other bugs, and removed a print statement.

Copy link

github-actions bot commented Jan 6, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 36 0 1.0s
✅ PYTHON pylint 36 0 5.79s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (18d0356) to head (f22af96).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   97.01%   97.02%   +0.01%     
==========================================
  Files          29       29              
  Lines        1842     1849       +7     
==========================================
+ Hits         1787     1794       +7     
  Misses         55       55              
Files with missing lines Coverage Δ
...stimation/genetic_programming_regression_fitter.py 98.86% <100.00%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2527b...f22af96. Read the comment docs.

@jmafoster1 jmafoster1 marked this pull request as ready for review January 6, 2025 09:40
@jmafoster1 jmafoster1 requested a review from f-allian January 6, 2025 09:40
@f-allian
Copy link
Contributor

f-allian commented Jan 6, 2025

@jmafoster1 Thanks Michael, I'll put some time aside to review this this afternoon.

Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmafoster1 Some quick fixes - see comments above.

@jmafoster1
Copy link
Contributor Author

Thanks @f-allian, fixed them all

@jmafoster1 jmafoster1 merged commit 7bf3f4c into main Jan 6, 2025
13 checks passed
@jmafoster1 jmafoster1 deleted the gp-fix branch January 6, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants