Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/backendtest #241

Merged
merged 60 commits into from
Sep 18, 2024
Merged

Feature/backendtest #241

merged 60 commits into from
Sep 18, 2024

Conversation

ayandajuqu
Copy link
Contributor

Pull Request

Description:

  1. added unit tests for modals used
  2. added 3d hotspot
  3. removed 3d true or false
  4. added 3d annotations

Related Issues:

[Reference any related issues or documents.]

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

[Any additional information that may be helpful for reviewers.]

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 614 lines in your changes missing coverage. Please review.

Project coverage is 25.10%. Comparing base (d774917) to head (13a16e3).
Report is 66 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/lib/components/annotations/3dAnnotations.svelte 0.00% 146 Missing ⚠️
src/src/lib/components/hotspot/3dhotspot.svelte 0.00% 109 Missing ⚠️
.../(app)/workspaces/[workspace]/quizzes/+page.svelte 0.00% 82 Missing ⚠️
...kspaces/[workspace]/quizzes/[quiz]/+page.server.ts 0.00% 57 Missing ⚠️
...workspaces/[workspace]/quizzes/[quiz]/+page.svelte 0.00% 37 Missing ⚠️
src/src/utils/keyboard.ts 0.00% 34 Missing ⚠️
src/src/lib/components/questions/3Dform.svelte 0.00% 33 Missing ⚠️
.../src/lib/components/questions/trueFalseForm.svelte 0.00% 33 Missing ⚠️
.../src/lib/components/questions/listQuestions.svelte 0.00% 24 Missing ⚠️
src/src/lib/components/hotspot/3dMenu.svelte 0.00% 22 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #241      +/-   ##
===========================================
- Coverage    26.11%   25.10%   -1.01%     
===========================================
  Files          190      197       +7     
  Lines         9356     9763     +407     
  Branches       472      459      -13     
===========================================
+ Hits          2443     2451       +8     
- Misses        6913     7312     +399     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bukhosi-eugene-mpande bukhosi-eugene-mpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessments look very good

Copy link
Contributor

@JoshuaTristanWereley JoshuaTristanWereley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@JoshuaTristanWereley JoshuaTristanWereley merged commit 57500a8 into develop Sep 18, 2024
4 of 6 checks passed
@ayandajuqu ayandajuqu deleted the feature/backendtest branch September 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants