Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable #273

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Stable #273

merged 6 commits into from
Sep 30, 2024

Conversation

bukhosi-eugene-mpande
Copy link
Contributor

Pull Request

Description:

[Provide a concise summary of your changes and why they are necessary.]

Related Issues:

[Reference any related issues or documents.]

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

[Any additional information that may be helpful for reviewers.]

Copy link
Contributor

@ayandajuqu ayandajuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit 4910fa2 into main Sep 30, 2024
6 checks passed
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.01%. Comparing base (1485cd1) to head (8d7ac67).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rc/src/lib/components/webspeech/speechSynthesis.ts 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   33.17%   33.01%   -0.16%     
==========================================
  Files          65       66       +1     
  Lines        4223     4243      +20     
  Branches      320      321       +1     
==========================================
  Hits         1401     1401              
- Misses       2822     2842      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Lunga-Ntando-Ndlovu Lunga-Ntando-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants