Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/integration #72

Merged
merged 14 commits into from
Jun 22, 2024
Merged

Update/integration #72

merged 14 commits into from
Jun 22, 2024

Conversation

JoshuaTristanWereley
Copy link
Contributor

Pull Request

Description:

I have added the integration code for materials and workspaces using the services contract for guidance

Related Issues:

Unable to test if the integration code works just yet

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Checklist:

  • I have read the CONTRIBUTING.md document.
  • My code follows the coding standards of this project.
  • I have performed a self-review of my code.
  • I have added/updated relevant documentation.
  • My changes generate no new warnings or errors.
  • I have tested my changes.

Reviewers:

Testing Instructions:

No testing instructions

Screenshots (if applicable):

N/A

Additional Notes:

N/A

Joshua Wereley and others added 13 commits June 22, 2024 11:05
Used The API contract to determine what response needs to be made when creating a workspace
Used The API contract to determine what response needs to be made when getting a workspace
Used The API contract to determine what response needs to be made when updating a workspace
Used The API contract to determine what response needs to be made when deleting a workspace
Used The API contract to determine what response needs to be made when posting a workspace.
Used The API contract to determine what response needs to be made when getting lecture material.
Changed endpoint and include the update workspace.
Includes the Delete Material Code
Includes List All Material Code
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (29314ea) to head (0c1e2e2).
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
+ Coverage    60.63%   66.88%   +6.25%     
===========================================
  Files           29       41      +12     
  Lines          315      450     +135     
  Branches        14       14              
===========================================
+ Hits           191      301     +110     
- Misses         122      147      +25     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bukhosi-eugene-mpande
Copy link
Contributor

I think this should go to develop first

@JoshuaTristanWereley JoshuaTristanWereley changed the base branch from main to develop June 22, 2024 16:36
Copy link
Contributor

@ayandajuqu ayandajuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit 917b67c into develop Jun 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants