Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fixes on Submission Box Page #521

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Conversation

te-sa
Copy link
Contributor

@te-sa te-sa commented Mar 27, 2024

Description:

I fixed the padding on the RHS of the page. I also extended the APIs so I can display the email of everyone that a submission was requested from.

Related Issues:

#514

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR

Screenshots or Visual Changes (if applicable):

Screenshot 2024-03-26 at 18 47 44

Documentation

Link to documentation if pages were added or changed.

@te-sa te-sa added the ui fix label Mar 27, 2024
@te-sa te-sa self-assigned this Mar 27, 2024
@te-sa te-sa linked an issue Mar 27, 2024 that may be closed by this pull request
@te-sa te-sa marked this pull request as ready for review March 27, 2024 02:19
Copy link

Component Test Results

Run start date: 3/27/2024, 5:05:35 PM

Duration: 6s

Tests run stats

  • 📚 total tests: 5
  • ✔️ passed: 5
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

Copy link

E2E Test Results

Run start date: 3/27/2024, 5:11:07 PM

Duration: 721s

Tests run stats

  • 📚 total tests: 147
  • ✔️ passed: 147
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@te-sa
Copy link
Contributor Author

te-sa commented Mar 27, 2024

Screenshot 2024-03-27 at 10 37 07

Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@te-sa te-sa merged commit 3a9123c into master Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Fixes on Submission Box Page
3 participants