Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to add and remove invited emails from a submission box #523

Merged
merged 14 commits into from
Apr 1, 2024
Merged

Add ability to add and remove invited emails from a submission box #523

merged 14 commits into from
Apr 1, 2024

Conversation

justino599
Copy link
Contributor

@justino599 justino599 commented Mar 29, 2024 •
edited
Loading

Description:

Add the ability to request more people to a submission box after the box has been created. And un-invite.

Related Issues:

Closes #522

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR

Screenshots or Visual Changes:

Recording.2024-03-30.121517.mp4

NOTE: The autofill popup not snapping to the input is a Chrome problem. I tried it on Firefox and it works as expected:
image

@justino599 justino599 added the task Task to complete for a feature label Mar 29, 2024
@justino599 justino599 self-assigned this Mar 29, 2024
@justino599 justino599 linked an issue Mar 29, 2024 that may be closed by this pull request
Invite users to existing submission box #522
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Component Test Results

Run start date: 3/31/2024, 10:25:09 PM

Duration: 5s

Tests run stats

  • 📚 total tests: 5
  • ✔️ passed: 5
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@justino599
Started making UI
be3d85b 
- Added X to member chips to uninvite users
- Added "Add Members" button
@justino599
Implemented functionality of requesting new submissions on frontend. …
c510e90 
…Also confirm uninviting member.
@justino599
Bug fix
7c7316b
@justino599 justino599 marked this pull request as ready for review March 30, 2024 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 30, 2024 •
edited
Loading

E2E Test Results

Run start date: 3/31/2024, 10:30:37 PM

Duration: 739s

Tests run stats

  • 📚 total tests: 154
  • ✔️ passed: 154
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

Hedgemon4
Hedgemon4 requested changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just some fixes and small suggestions.

@Hedgemon4 Hedgemon4 marked this pull request as draft March 30, 2024 23:13
te-sa
te-sa requested changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@te-sa te-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good over all, just have one request

ketphan02
ketphan02 reviewed Mar 31, 2024
View reviewed changes
Copy link
Contributor

@ketphan02 ketphan02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall!

I main thing is let's not allow them to edit the submission box if they are not in the edit mode

@justino599
Copy link
Contributor Author

justino599 commented Mar 31, 2024 •
edited
Loading

Nice work overall!

I main thing is let's not allow them to edit the submission box if they are not in the edit mode

@ketphan02 Sorry, how is this relevant to this PR? I didn't change anything about editing and that is a behavior that already exists...

@justino599 justino599 marked this pull request as ready for review March 31, 2024 21:41
@justino599 justino599 requested review from te-sa and Hedgemon4 March 31, 2024 21:43
Hedgemon4
Hedgemon4 previously approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing my requests.

te-sa
te-sa approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@te-sa te-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justino599 justino599 merged commit cd239cb into master Apr 1, 2024
7 checks passed
@justino599 justino599 deleted the 522-invite-users-to-existing-submission-box branch April 1, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketphan02 ketphan02 ketphan02 left review comments

@te-sa te-sa te-sa approved these changes

@Hedgemon4 Hedgemon4 Hedgemon4 approved these changes

@SecondFeline SecondFeline Awaiting requested review from SecondFeline

Assignees

@justino599 justino599

Labels
task Task to complete for a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invite users to existing submission box
4 participants
@justino599 @ketphan02 @te-sa @Hedgemon4