Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Access deny when trying to access video through submission box as submission box owner #526

Merged
merged 5 commits into from
Apr 2, 2024
Merged

[Bug] Access deny when trying to access video through submission box as submission box owner #526

merged 5 commits into from
Apr 2, 2024

Conversation

ketphan02
Copy link
Contributor

@ketphan02 ketphan02 commented Mar 31, 2024 •
edited
Loading

Description:

  • The issue is caused because we did not update the whitelist when the user
  • Create whitelisted users for all submission boxes
  • Remove whitelisted users after unsubmitting

Related Issues:

Closes #525

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR

@ketphan02 ketphan02 added the bug Something isn't working label Mar 31, 2024
@ketphan02 ketphan02 self-assigned this Mar 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

Component Test Results

Run start date: 4/2/2024, 7:23:47 PM

Duration: 5s

Tests run stats

  • 📚 total tests: 5
  • ✔️ passed: 5
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02 ketphan02 marked this pull request as ready for review March 31, 2024 02:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

E2E Test Results

Run start date: 4/2/2024, 8:19:52 PM

Duration: 825s

Tests run stats

  • 📚 total tests: 164
  • ✔️ passed: 164
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@Hedgemon4 Hedgemon4 marked this pull request as draft March 31, 2024 16:40
@ketphan02 ketphan02 marked this pull request as ready for review April 1, 2024 02:22
@ketphan02 ketphan02 requested a review from Hedgemon4 April 1, 2024 02:22
justino599
justino599 requested changes Apr 1, 2024
View reviewed changes
@ketphan02 ketphan02 requested a review from justino599 April 2, 2024 19:27
Hedgemon4
Hedgemon4 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Hedgemon4
Hedgemon4 requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test

@ketphan02 ketphan02 requested a review from Hedgemon4 April 2, 2024 20:49
Hedgemon4
Hedgemon4 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the test

@ketphan02 ketphan02 merged commit 401e244 into master Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justino599 justino599 justino599 approved these changes

@Hedgemon4 Hedgemon4 Hedgemon4 approved these changes

@te-sa te-sa Awaiting requested review from te-sa

@SecondFeline SecondFeline Awaiting requested review from SecondFeline

Assignees

@ketphan02 ketphan02

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access deny when trying to access video through submission box as submission box owner
3 participants
@ketphan02 @justino599 @Hedgemon4