-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to video cards #527
Conversation
Component Test Results
Tests run stats
Failed testsClick to revealSkipped testsClick to revealSkipped tests by CypressClick to reveal |
# Conflicts: # src/app/submission-box/[boxId]/page.tsx
E2E Test Results
Tests run stats
Failed testsClick to revealSkipped testsClick to revealSkipped tests by CypressClick to reveal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests. I'm loving all the changes to the video cards :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description:
@Hedgemon4 suggested in my last PR that we add more info to the video cards inside submission boxes, e.g. who submitted and when. This PR addresses that. It required augmenting one of our APIs, and introducing some more conditional logic into the video card.
Related Issues:
#524
Checklist:
Before submitting this pull request, please make sure of the following:
master
branch.Screenshots or Visual Changes (if applicable):
Documentation
Link to documentation if pages were added or changed.