Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to video cards #527

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Conversation

te-sa
Copy link
Contributor

@te-sa te-sa commented Mar 31, 2024

Description:

@Hedgemon4 suggested in my last PR that we add more info to the video cards inside submission boxes, e.g. who submitted and when. This PR addresses that. It required augmenting one of our APIs, and introducing some more conditional logic into the video card.

Related Issues:

#524

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR

Screenshots or Visual Changes (if applicable):

Screenshot 2024-03-30 at 21 40 06 Screenshot 2024-03-30 at 21 40 16

Documentation

Link to documentation if pages were added or changed.

@te-sa te-sa linked an issue Mar 31, 2024 that may be closed by this pull request
@te-sa te-sa marked this pull request as ready for review March 31, 2024 04:41
Copy link

github-actions bot commented Mar 31, 2024

Component Test Results

Run start date: 4/2/2024, 1:26:41 AM

Duration: 5s

Tests run stats

  • 📚 total tests: 5
  • ✔️ passed: 5
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@te-sa te-sa self-assigned this Mar 31, 2024
@te-sa te-sa added the task Task to complete for a feature label Mar 31, 2024
@te-sa
Copy link
Contributor Author

te-sa commented Mar 31, 2024

Screenshot 2024-03-30 at 22 31 39

@Hedgemon4 Hedgemon4 marked this pull request as draft March 31, 2024 16:40
@te-sa te-sa requested a review from Hedgemon4 April 2, 2024 01:24
@te-sa te-sa marked this pull request as ready for review April 2, 2024 01:24
Copy link

github-actions bot commented Apr 2, 2024

E2E Test Results

Run start date: 4/2/2024, 1:33:22 AM

Duration: 866s

Tests run stats

  • 📚 total tests: 156
  • ✔️ passed: 156
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

Copy link
Contributor

@SecondFeline SecondFeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests. I'm loving all the changes to the video cards :)

Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@te-sa te-sa merged commit 355c67f into master Apr 2, 2024
11 checks passed
@te-sa te-sa added this to the Final Project Submission milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task to complete for a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more info to video cards
3 participants