Suggest edits to setup docs PR #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component Test Results
Tests run stats
Failed testsClick to revealSkipped testsClick to revealSkipped tests by CypressClick to reveal |
E2E Test Results
Tests run stats
Failed testsClick to revealSkipped testsClick to revealSkipped tests by CypressClick to reveal |
Hedgemon4
requested changes
Apr 5, 2024
te-sa
reviewed
Apr 6, 2024
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| 1. Go to the [AWS console](https://ubc-cicsso.awsapps.com/start#/) | |||
| 2. Click on your AWS account, and choose: `Access Keys` | |||
| 3. Ensure the correct OS tab is selected at the top: The default is macOS and Linux | |||
| 4. After selecting your OS, follow the instructions under: Option 1: Set AWS environment variables | |||
| 3. Select Mac/Linux as your OS, copy the text for _Option 1: Set AWS environment variables_. The three keys copied from here (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY,AWS_SESSION_TOKEN) need to be pasted into the two environment files without the "export". | |||
There was a problem hiding this comment.
Should it always be Mac/Linux even if their computer is windows?
te-sa
approved these changes
Apr 6, 2024
te-sa
merged commit 96686b9
into
536-update-readme-installation-and-setup-instructions
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits I would make to the current PR updating the setup docs (#537)