-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xgcm operations #220
Xgcm operations #220
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'll have a look! |
Just had a quick look at this -- will look carefully soon. Seems like we can ditch the Relative vorticity example and keep this one? What do you think? |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-01-30T01:10:44Z Line #2. rel_vort_region.plot() Change to
otherwise it's like a blank plot. julia-neme commented on 2023-09-04T04:39:49Z I would probably delete this map and go straight to the circumpolar plot |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-01-30T01:10:45Z Line #1. foo = xr.open_dataset('/g/data/ik11/outputs/mom6-panan/panant-v2/output090/19980701.ocean_daily.nc') let's not |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-01-30T01:10:46Z Line #3. ds_panant = ds_panant.rename({'latq':'yq'}).rename({'lath':'yh'}).rename({'lonq':'xq'}).rename({'lonh':'xh'}) why do you rename? is it needed? perhaps we should explain? (would |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-01-30T01:10:47Z Line #22. grid = xgcm.Grid(ds_panant, coords={'X':{'center':'xh', 'left':'xq'}, I feel that the grid construction belongs to its own cell with a bit of a remark on how this is a bit different than before making the connection with MOM5 being B-grid while MOM6 C-grid? |
I had a quick go and put a few comments. It's a bit rough... but I'm keen to work to polish it.
|
Thanks Navid
Absolutely. I didn't spend time polishing it, because I wanted to have a conversation about what we wanted the final result to look like before doing that. (And there were other people working on
Oh definitely. Now that I've learnt about
I think there's scope for it to be a tutorial. Performing grid-aware operations is a sufficiently basic task that that most users will need to do it and |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-02-10T10:16:20Z Line #1. sim = '0.1RYF' Would the tutorial here break if we load 0.25-degree output? julia-neme commented on 2023-09-04T04:29:43Z Also, why wouldn't this work with IAF? This could be probably generalised to whatever access experiment we want right? An option could be adding a line that defines the experiment, and explaining that it can be changed to whatever experiment is of interest? |
View / edit / reply to this conversation on ReviewNB navidcy commented on 2023-02-10T10:16:21Z Line #4. ocean_grid = xr.open_dataset('/g/data/ik11/outputs/access-om2-01/01deg_jra55v13_ryf9091/output000/ocean/ocean_grid.nc') can we use cosima cookbook to load this? I don't like hardcoding the path of the
|
@edoddridge should we aim to finish this during this hackathon? do you wanna push this or you have something else in mind for Monday's hackathon? |
We definitely should. I'll be in transit for much of Monday :( so I'm not sure I should lead it, but am happy to pick it up when I arrive if nobody else has. |
Also, why wouldn't this work with IAF? This could be probably generalised to whatever access experiment we want right? View entire conversation on ReviewNB |
I would probably delete this map and go straight to the circumpolar plot View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:27Z I would maybe add a description here with what this notebook does, and maybe divide in sections so that it is easier to browse the notebook. For example: a section that loads necessary variables, a section that creates the grid info, and a section with example calculations |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:28Z Line #19. %matplotlib inline I don't think this is necessary |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:28Z This is me being ignorant, but what is the difference between this and doing Client()? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:29Z Wouldn't it be more efficient to make this selection for U and V before calculating relative vorticity? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:30Z The equation is not rendering for me. |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:31Z As per relative vorticity comment above, might be better to load U selection before calculating and computing? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:32Z Could we put the units in Sverdrup? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2023-09-04T04:44:32Z Could you make this figure into a circumpolar map like the others? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per comments in reviewNB
First pass at a notebook that pulls in all the metrics required to create an
xgcm
grid object.It's all pretty rough and ready at the moment. The MOM6 example at the end is especially rough.
closes #164