Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rely on HTML table rendering instead of images #32

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Mar 25, 2024

This PR addresses a prior issue with HTML rendering which involved static image workarounds (fixed in a recent release of LWT).

Closes #31

Copy link

github-actions bot commented Mar 25, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://CU-DBMI.github.io/set-website/preview/pr-32/
on branch gh-pages at 2024-04-22 21:32 UTC

@d33bs
Copy link
Member Author

d33bs commented Mar 25, 2024

Looks like the build fails based on a bundler and Ruby dependency challenge.

7:53:32 AM: ERROR:  Error installing bundler:
7:53:32 AM: 	There are no versions of bundler (= 2.5.6) compatible with your Ruby & RubyGems
7:53:32 AM: 	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.2.137.

@CU-DBMI CU-DBMI deleted a comment from netlify bot Mar 25, 2024
@vincerubinetti
Copy link

Netlify by default comes with Ruby 2.7 installed, and a recent template version (I think v1.2.0) updated Gem versions such that we need Ruby > 3.0. This is okay because Netlify hasn't been the recommended way to do PR previews since v1.0.0. The PR preview action seems to have worked fine.

I see that the post has some dangling </table> tags that weren't closed properly.

@vincerubinetti
Copy link

vincerubinetti commented Mar 25, 2024

Playing around locally, it seems like the <strong> before the nested <table> is what's causing the issue. If I wrap the two in a <div>, such that the <td> only has one child, it works. This must be some bug in the markdown parser. At least it's not an issue with the template this time.

@vincerubinetti
Copy link

Turns out this is an issue with jekyll spaceship, very weird:

jeffreytse/jekyll-spaceship#97

@vincerubinetti
Copy link

vincerubinetti commented Apr 19, 2024

Unfortunately, it seems like jekyll-spaceship hasn't been updated in years and that bug is unlikely to be fixed. But it provides too much value to be disabled outright imo. So the <div> wrapper work-around would be recommended here.

I would update it myself, but it's a fork and I don't think I have permissions. If you want to update this, we can merge and close.

@d33bs
Copy link
Member Author

d33bs commented Apr 22, 2024

Thanks for the follow up, I tried to wrap the nested tables and saw that the rendering still looks a bit unusual. Maybe it's the multiple nested tables that's throwing it off? I can also close without merge here if it'd be best.

image

@vincerubinetti
Copy link

The opening <div> should go above the <strong>. The bug happens when a <td> has more than one child.

@d33bs
Copy link
Member Author

d33bs commented Apr 23, 2024

Thank you @vincerubinetti for your help with this! Merging this in.

@d33bs d33bs merged commit b9e6376 into CU-DBMI:main Apr 23, 2024
2 checks passed
@d33bs d33bs deleted the html-tables-update branch April 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update commented HTML tables to be rendered by LWT
2 participants