Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added incoming websocket message display #21

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Added incoming websocket message display #21

merged 3 commits into from
Nov 24, 2023

Conversation

3milyfz
Copy link
Member

@3milyfz 3milyfz commented Nov 23, 2023 •
edited
Loading

Description

  • Incoming websocket messages are now displayed in Chat component!
  • Attempted to follow a listener/observer design pattern
quickDemo.mov

@3milyfz 3milyfz self-assigned this Nov 23, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 23, 2023 •
edited
Loading

✅ Deploy Preview for callhub ready!

Name Link
🔨 Latest commit 8f7c3b8
🔍 Latest deploy log https://app.netlify.com/sites/callhub/deploys/655ec949db4a8c0008cb5584
😎 Deploy Preview https://deploy-preview-21--callhub.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lucieyang1
lucieyang1 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@lucieyang1 lucieyang1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It works on my end. Amazing

It doesn't look like you used a listener/observer. Did we want to do that?

@3milyfz
Copy link
Member Author

3milyfz commented Nov 23, 2023 •
edited
Loading

LGTM! It works on my end. Amazing

It doesn't look like you used a listener/observer. Did we want to do that?

Okay edit, I refactored the code to have an observable!

zjayee
zjayee approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@zjayee zjayee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Coding style: follows naming conventions, code formatting is clean and easy to follow
  • Correctness: This runs correctly locally for me!
  • Good use of the observable design pattern
  • I really like the demo video included with this pull request

LGTM

@3milyfz 3milyfz merged commit 0723763 into main Nov 24, 2023
@3milyfz 3milyfz deleted the websocket-message-listener branch November 26, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjayee zjayee zjayee approved these changes

@lucieyang1 lucieyang1 lucieyang1 approved these changes

@sarinali sarinali Awaiting requested review from sarinali

Assignees

@3milyfz 3milyfz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3milyfz @zjayee @lucieyang1