Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored frontend #32

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Refactored frontend #32

merged 3 commits into from
Nov 26, 2023

Conversation

3milyfz
Copy link
Member

@3milyfz 3milyfz commented Nov 26, 2023 •
edited
Loading

Description

  • Separated components and helper components
  • Separated components and their styling
  • Removed test button component
  • Removed unnecessary routes from App.jsx

Type of change

  • Code improvement

How Has This Been Tested?

  • Tested locally

@netlify Netlify
Copy link

netlify bot commented Nov 26, 2023 •
edited
Loading

✅ Deploy Preview for callhub ready!

Name Link
🔨 Latest commit 7f37df2
🔍 Latest deploy log https://app.netlify.com/sites/callhub/deploys/6562cca13c446500085b9d41
😎 Deploy Preview https://deploy-preview-32--callhub.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3milyfz 3milyfz self-assigned this Nov 26, 2023
zjayee
zjayee approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@zjayee zjayee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code is much cleaner now, nice work!

@3milyfz 3milyfz merged commit 4709501 into main Nov 26, 2023
4 checks passed
@3milyfz 3milyfz deleted the refactor-frontend branch November 26, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjayee zjayee zjayee approved these changes

@sarinali sarinali Awaiting requested review from sarinali

@lucieyang1 lucieyang1 Awaiting requested review from lucieyang1

Assignees

@3milyfz 3milyfz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3milyfz @zjayee