Update tools to 0.5.0 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2025
|
Note to myself: The |
|
This is now updated to use version 0.5.0 of the 3D Tiles Tools, which was just released. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Builds on #331 )
This updates the 3D Tiles Tools for the upcoming 0.5.0 release ( CesiumGS/3d-tiles-tools#174 )
The main change for the (breaking) change to use the
asyncAPI was pretty trivial - it just needed anawaitin a few places.A minor change resulted from this commit: Previously, the
TraversedTilereturned a 'subtree URI' for both the explicit tile that defined the implicit tiling, and for the implicit root tile. Now, it only returns it for the implicit root tile. This should usually not affect clients. But the validator is a different beast: It has to explicitly access the.subtreefile to perform an eager validation before even starting the traversal.A small change (that belongs to CesiumGS/3d-tiles-tools@5afdeab ) is: Previously, content types that are "known but not validated" (like
VCTR,GEOM, andGEOJSON) caused a WARNING saying "Skipping type validation". Now, this only is an INFO. The reasoning behind that is that the user can not do anything to "fix" this, so a WARNING does not seem warranted.