Lighthouse eth2 implementation #346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 54.24% 54.24%
=======================================
Files 61 61
Lines 955 955
Branches 112 112
=======================================
Hits 518 518
Misses 415 415
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/renderer/services/eth2/client/eth2ApiClient/beaconBlocks.ts
Outdated
Show resolved
Hide resolved
src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconApi.ts
Outdated
Show resolved
Hide resolved
| } | ||
| }; | ||
|
|
||
| public getChainHead = async (): Promise<BeaconBlock> => { |
There was a problem hiding this comment.
can you move this inside CgEth2BeaconBlocksApi
There was a problem hiding this comment.
@BeroBurny I don't see this resolved!
There was a problem hiding this comment.
there is no point for holding this method if is not used by any code from the validator
There was a problem hiding this comment.
It's not used by validator but it's used by chainguardian
src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconStateApi.ts
Outdated
Show resolved
Hide resolved
src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconStateApi.ts
Outdated
Show resolved
Hide resolved
src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconStateApi.ts
Outdated
Show resolved
Hide resolved
src/renderer/services/eth2/client/eth2ApiClient/cgEth2EventsApi.ts
Outdated
Show resolved
Hide resolved
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| public onNewChainHead = (callback: (head: IEth2ChainHead) => void): NodeJS.Timeout => { | ||
| throw new Error("Method 'onNewChainHead' not implemented."); |
There was a problem hiding this comment.
@BeroBurny I don't see this implemented anywhere?
There was a problem hiding this comment.
It is not used by any part of the code, if will be required it will be implemented correctly
There was a problem hiding this comment.
It's not used by validator but it's used by chainguardian. It's used to display beacon node current slot when syncing. You always used synced node so that part of code wasn't executed
# Conflicts: # src/renderer/services/eth2/networks/local.ts
closes #337