feat: add a thread_rng wrapper that that can be overriden by reproduc…

…ible seeded rng (#5375)

Co-authored-by: Hubert <hubert@chainsafe.io>

.clippy.toml

@@ -24,6 +24,18 @@ use parking_lot::Mutex instead to silently ignore panics."""
 path = "multihash_codetable::Code"
 reason = """use `crate::utils::multihash::MultihashCode` instead which has `Identity` code back-filled."""
 
+[[disallowed-types]]
+path = "rand::rngs::ThreadRng"
+reason = """use `crate::utils::forest_rng` instead."""
+
+[[disallowed-types]]
+path = "rand::rngs::OsRng"
+reason = """use `crate::utils::forest_os_rng` instead."""
+
+[[disallowed-methods]]
+path = "rand::thread_rng"
+reason = """use `crate::utils::forest_rng` instead."""
+
 [[disallowed-methods]]
 path = "tempfile::NamedTempFile::new"
 reason = """The temporary files created by this method are not persistable if the temporary directory lives on a different filesystem than the target directory. While it is valid in other contexts (if not persisting files), it was misused many times and so we are banning it. Consider using `tempfile::NamedTempFile::new_in` or `tempfile::NamedTempFile::Builder"""

CHANGELOG.md

@@ -29,6 +29,8 @@
 
 ### Added
 
+- [#5375](https://github.com/ChainSafe/forest/issues/5375) Add an RNG wrapper that that can be overriden by a reproducible seeded RNG.
+
 ### Changed
 
 ### Removed

Cargo.toml

@@ -163,6 +163,7 @@ prometheus-client = "0.22"
 quick-protobuf = "0.8"
 quick-protobuf-codec = "0.3"
 rand = "0.8"
+rand_chacha = "0.3"
 rand_distr = "0.4"
 raw_sync_2 = "0.1"
 rayon = "1"

docs/dictionary.txt

@@ -79,6 +79,7 @@ preload
 preloaded
 Q4
 README
+RNG
 Roadmap
 roadmap
 RPC