Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix snapshot parity test and schedule it to be weekly #5373

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 4, 2025

Summary of changes

The snapshot parity test start failing since we move back to GH hosted runners due to insufficient RAM and disk space.
This PR moves it back to buildjet runners and schedule it weekly to reduce cost.

Successful test run: https://github.com/ChainSafe/forest/actions/runs/13650828365/job/38158739597?pr=5373
Issue on failure: #5374

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 force-pushed the hm/ci-snapshot-parity-cron branch from 552b12f to fd8335b Compare March 4, 2025 09:46
@hanabi1224 hanabi1224 marked this pull request as ready for review March 4, 2025 10:01
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 4, 2025 10:01
@hanabi1224 hanabi1224 requested review from lemmih, sudo-shashank and LesnyRumcajs and removed request for a team March 4, 2025 10:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rather use edge-fat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires some extra setup to share the preloaded proof files with lotus tho. I'm not sure if it's worth the effort. What's your suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if we had something like this, re-usable across different workflows. Our CI failed so many times because Lotus failed to download the proofs from their source. Not a blocker for this PR, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can implement this in a subsequent PR to mitigate the issue in all workflows

@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 5150593 Mar 4, 2025
47 checks passed
@hanabi1224 hanabi1224 deleted the hm/ci-snapshot-parity-cron branch March 4, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants