Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate project to NestJS. #149

Merged
merged 13 commits into from
Jul 22, 2024
Merged

feat: migrate project to NestJS. #149

merged 13 commits into from
Jul 22, 2024

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Jun 8, 2024 •
edited
Loading

Closes #138
Closes #154

@35C4n0r 35C4n0r requested a review from ChakshuGautam June 8, 2024 08:42
@35C4n0r 35C4n0r mentioned this pull request Jun 8, 2024
Closed
13 tasks
@35C4n0r 35C4n0r self-assigned this Jun 8, 2024
@35C4n0r 35C4n0r added the DMP24 label Jun 8, 2024
@35C4n0r 35C4n0r marked this pull request as draft June 8, 2024 08:48
@35C4n0r 35C4n0r marked this pull request as ready for review June 9, 2024 06:24
@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Jul 1, 2024 •
edited
Loading

So, I was setting up the project through steps mentioned in README.md.
Got this error while running
npx ts-node parse.geojson.ts
Error: Cannot find module './parse.geojson.ts'

It seems this is outdated. And needs to be updated. There is no <project-root>/scripts folder anymore. It's now inside of <project-root>/src/

parse.geojson.ts creates required files for the service to run. And therefore the service is not running up as well.
Can you make sure it's working fine?

35C4n0r added 2 commits July 3, 2024 15:56
@35C4n0r
fix: fix scripts and Dockerfile
75bae01 
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
fix: fix city.service.spec.ts test.
3f49db7 
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@dhruv-1001 dhruv-1001 merged commit 15ab9c1 into ChakshuGautam:master Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChakshuGautam ChakshuGautam Awaiting requested review from ChakshuGautam

Assignees

@35C4n0r 35C4n0r

Labels
DMP24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(MD) Add e2e tests for backend. Migration to NestJs
2 participants
@35C4n0r @dhruv-1001