Skip to content

Commit

Permalink
Regression: Re-deploy missing rrdtool cli binaries
Browse files Browse the repository at this point in the history
Change-Id: I5d19db2c3e46c5c88b310aff22ddb0b8a4e9c6d0
  • Loading branch information
TimotheusBachinger committed Feb 6, 2025
1 parent 0821611 commit 77b033b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
17 changes: 16 additions & 1 deletion omd/packages/rrdtool/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ load("//bazel/rules:package_wheel.bzl", "package_wheel")
rrd_cli_tools = [
"rrdtool",
"rrdcached",
"rrdupdate",
]

rrd_cli_symlinks = [
"rrdcreate",
"rrdinfo",
]

[genrule(
Expand Down Expand Up @@ -39,6 +45,15 @@ pkg_files(
prefix = "lib",
)

[
pkg_mklink(
name = "%s_symlink" % b,
link_name = "bin/%s" % b,
target = "bin/rrdupdate",
)
for b in rrd_cli_symlinks
]

pkg_mklink(
name = "librrd_symlink",
# The "8" is the version of the library - no idea yet how to get this
Expand All @@ -53,7 +68,7 @@ pkg_filegroup(
":rrdtool_bin",
":rrdtool_lib",
":rrdtool_skel_pkg",
],
] + ["%s_symlink" % b for b in rrd_cli_symlinks],
visibility = ["//visibility:public"],
)

Expand Down
3 changes: 3 additions & 0 deletions tests/integration/omd/test_rrdtool.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ def test_cli_xport(
[
(["rrdtool"], 0, "RRDtool"),
(["rrdcached", "--help"], 1, "RRDCacheD"),
(["rrdupdate"], 1, "RRDtool"),
(["rrdcreate"], 1, "RRDtool"),
(["rrdinfo"], 1, "RRDtool"),
],
)
def test_additional_cli_tools(
Expand Down

0 comments on commit 77b033b

Please sign in to comment.