Add 3.11 to images with newer openssl as needed - also update sqlite #93
Conversation
| wget -q https://sqlite.org/2022/sqlite-autoconf-3400100.tar.gz && \ | ||
| tar -xzf sqlite-autoconf-3400100.tar.gz && \ | ||
| cd sqlite-autoconf-3400100 && \ | ||
| wget -q https://www.sqlite.org/2024/sqlite-autoconf-3450100.tar.gz && \ |
There was a problem hiding this comment.
where do we document and/or check our required sqlite minimum version? is this ok with that?
| # Compile newer version of python3 | ||
| RUN yum -y install openssl openssl-devel zlib-devel bzip2 bzip2-devel readline-devel tk-devel libffi-devel xz-devel && \ | ||
| cd ~ && \ | ||
| # Set up pyenv \ | ||
| git clone https://github.com/pyenv/pyenv.git ~/.pyenv && \ | ||
| pyenv install 3.10 && \ | ||
| # setup python 3.10 \ | ||
| PYTHON_CONFIGURE_OPTS="--enable-shared --enable-optimizations" pyenv install 3.10 && \ |
There was a problem hiding this comment.
do we want to be changing 3.10 configure options?
| # setup python 3.10 \ | ||
| PYTHON_CONFIGURE_OPTS="--enable-shared --enable-optimizations" pyenv install 3.10 && \ | ||
| # setup python 3.11 w/ openssl 3 \ | ||
| PYTHON_CONFIGURE_OPTS="--with-openssl=/usr/local/ssl --with-openssl-rpath=auto --enable-shared --enable-optimizations" pyenv install 3.11 && \ |
There was a problem hiding this comment.
review the details of optimizations specifically related to asserts being disabled
| pyenv global 3.10 && \ | ||
| pip install --upgrade pip && \ | ||
| pip install --no-cache-dir py3createtorrent awscli && \ | ||
| python3 -c 'import sys; import sqlite3; sys.exit(sqlite3.sqlite_version != "3.40.1")' && \ | ||
| python3 -c 'import sys; import sqlite3; sys.exit(sqlite3.sqlite_version != "3.45.1")' && \ |
There was a problem hiding this comment.
do we want to be changing the sqlite version in 3.10? i know that it would be more hassle to have two versions. just make sure we plan accordingly.
| pip install --upgrade pip && \ | ||
| pip install --no-cache-dir py3createtorrent awscli && \ |
There was a problem hiding this comment.
eh? what for? global installs usually not great.
There was a problem hiding this comment.
Because there were some things in the past that assumed these were present. We might have actually fixed all those. If you can't find any examples of assuming this was installed globally, we can probably drop this.
There was a problem hiding this comment.
aws cli is probably useful to keep, since its more of a system level tool than specific to any one project/package, but dropping the torrent thing if its not assumed global is fine with me
Attempt to do this in a smarter way
Add python 3.11 rather than replace 3.10 so both should be available in the build image.
Update sqlite to 3.45.1 for both
Install openssl 3 on Ubuntu 20 and Rocky8 and use for python 3.11 only
This image should then be able to be used with either 3.10 or 3.11 (w/ updated openssl) as needed