Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more bytes32.from_hexstr() #18446

Merged
merged 1 commit into from
Aug 14, 2024
Merged

more bytes32.from_hexstr() #18446

merged 1 commit into from
Aug 14, 2024

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 12, 2024
@altendky altendky marked this pull request as ready for review August 13, 2024 17:48
@altendky altendky requested a review from a team as a code owner August 13, 2024 17:48
@altendky altendky requested a review from emlowe August 13, 2024 17:50
@altendky altendky closed this Aug 14, 2024
@altendky altendky reopened this Aug 14, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/rpc/data_layer_rpc_api.py 77.8% lines 52, 339
chia/rpc/farmer_rpc_api.py 0.0% lines 356
chia/simulator/simulator_full_node_rpc_client.py 0.0% lines 35
Total Missing Coverage
35 lines 4 lines 88%

Copy link

Pull Request Test Coverage Report for Build 10392470254

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 9 files are covered.
  • 31 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.859%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/rpc/farmer_rpc_api.py 0 1 0.0%
chia/simulator/simulator_full_node_rpc_client.py 0 1 0.0%
chia/rpc/data_layer_rpc_api.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.82%
chia/wallet/wallet_node.py 1 89.01%
chia/_tests/core/util/test_lockfile.py 4 89.47%
chia/server/server.py 4 82.21%
chia/server/node_discovery.py 5 79.79%
chia/full_node/full_node.py 5 85.85%
chia/timelord/timelord.py 11 80.6%
Totals Coverage Status
Change from base Build 10391365490: -0.01%
Covered Lines: 101382
Relevant Lines: 111552

💛 - Coveralls

@Starttoaster Starttoaster merged commit 7d88089 into main Aug 14, 2024
738 of 740 checks passed
@Starttoaster Starttoaster deleted the more_bytes32_from_hexstr branch August 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants