[CHIA-1126] Remove PrivateKey type from wallet
#18458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
force-pushed
the
quex.remove_bls_only_from_wallet
branch
from
9bfb7f7 to
586cab7
Compare
Quexington
added
Changed
Quexington
changed the title
PrivateKey type from walletPrivateKey type from wallet
Base automatically changed from
quex.add_secret_info_protocol
to
long_lived/vault
August 14, 2024 17:02
geoffwalmsley
approved these changes
Aug 14, 2024
markelrod
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to remove the
PrivateKeytype from the wallet insofar as is possible. The object is to be able to use any type of private key with the wallet's.private_keymember variable.