-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-1128] Generalize Keychain to support multiple key types #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Aug 13, 2024
Quexington
changed the title
Generalize Keychain to support multiple key types
[CHIA-1128] Generalize Keychain to support multiple key types
Aug 14, 2024
Quexington
requested review from
geoffwalmsley
and removed request for
geoffwalmsley
August 15, 2024 14:07
Quexington
changed the base branch from
merge/quex.dedup_keychain_code+quex.add_secp_to_key_types
to
long_lived/vault
August 20, 2024 16:39
github-actions
bot
added
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Sep 9, 2024
github-actions
bot
removed
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Sep 9, 2024
|
emlowe
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
vault
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of vaults, in order to preserve existing UX where the wallet can perform all actions by itself, you need a secp private key available to the wallet. In order to store these private keys in the keychain, this PR generalizes the keychain code to support keys of any type.