Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1128] Generalize Keychain to support multiple key types #18466

Merged
merged 12 commits into from
Sep 16, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Aug 13, 2024

With the advent of vaults, in order to preserve existing UX where the wallet can perform all actions by itself, you need a secp private key available to the wallet. In order to store these private keys in the keychain, this PR generalizes the keychain code to support keys of any type.

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 13, 2024
@Quexington Quexington changed the title Generalize Keychain to support multiple key types [CHIA-1128] Generalize Keychain to support multiple key types Aug 14, 2024
@Quexington Quexington requested review from geoffwalmsley and removed request for geoffwalmsley August 15, 2024 14:07
@Quexington Quexington changed the base branch from merge/quex.dedup_keychain_code+quex.add_secp_to_key_types to long_lived/vault August 20, 2024 16:39
@Quexington Quexington marked this pull request as ready for review August 20, 2024 16:43
@Quexington Quexington requested a review from a team as a code owner August 20, 2024 16:43
@Chia-Network Chia-Network deleted a comment from github-actions bot Aug 21, 2024
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Aug 21, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Sep 9, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 9, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Sep 10, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Sep 10, 2024
@Quexington Quexington closed this Sep 12, 2024
@Quexington Quexington reopened this Sep 12, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/keys.py 40.0% lines 339-340, 394-395, 475-476
chia/cmds/keys_funcs.py 89.7% lines 325-326, 331
chia/cmds/sim_funcs.py 0.0% lines 38-39, 155-157, 184
chia/farmer/farmer.py 83.3% lines 237
chia/plotting/check_plots.py 0.0% lines 11
chia/plotting/create_plots.py 33.3% lines 99, 105, 109, 114, 118-119
chia/util/keychain.py 97.1% lines 425, 574
chia/wallet/wallet_node.py 94.7% lines 450
Total Missing Coverage
238 lines 26 lines 89%

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Sep 16, 2024
@Quexington Quexington merged commit d2f5d0a into long_lived/vault Sep 16, 2024
742 of 744 checks passed
@Quexington Quexington deleted the quex.generalize_keychain branch September 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants