Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for wallet sync in async_split() #18472

Closed
wants to merge 3 commits into from

Conversation

altendky
Copy link
Contributor

Purpose:

#15527

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 14, 2024
Copy link

coveralls-official bot commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10761697946

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • 20 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/coin_funcs.py 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.82%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/full_node/full_node.py 2 86.83%
chia/server/ws_connection.py 3 87.96%
chia/wallet/wallet_node.py 4 88.44%
chia/full_node/weight_proof.py 4 90.51%
chia/_tests/core/util/test_lockfile.py 5 89.47%
Totals Coverage Status
Change from base Build 10745304670: 0.04%
Covered Lines: 101623
Relevant Lines: 111718

💛 - Coveralls

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

File Coverage Missing Lines
chia/cmds/coin_funcs.py 72.7% lines 216, 218-219
Total Missing Coverage
11 lines 3 lines 72%

@altendky altendky closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage-diff Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant