Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate KvID to KeyId and ValueId #19180

Merged

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jan 24, 2025
@altendky altendky marked this pull request as ready for review January 24, 2025 15:55
@altendky altendky requested a review from a team as a code owner January 24, 2025 15:55
AmineKhaldi
AmineKhaldi previously approved these changes Jan 24, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/data_store.py 96.0% lines 1062
Total Missing Coverage
60 lines Unknown 98%

@altendky altendky merged commit 137bd80 into long_lived/datalayer_merkle_blob Jan 25, 2025
299 of 300 checks passed
@altendky altendky deleted the separate_key_and_value_id_types branch January 25, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants