Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check_fork_next_block.py to chia.full_node #19193

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Move check_fork_next_block.py to chia.full_node #19193

merged 1 commit into from
Jan 28, 2025

Conversation

richardkiss
Copy link
Contributor

This is a reorganization only, to remove a dependency of chia.util on chia.full_node.

Purpose:

Move a file out of chia.util that depends on too many other things. It's only used in chia.full_node so this is a more natural place for it.

Current Behavior:

New Behavior:

Testing Notes:

@richardkiss richardkiss requested a review from a team as a code owner January 28, 2025 01:14
@richardkiss richardkiss added Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels Jan 28, 2025
@richardkiss richardkiss requested a review from altendky January 28, 2025 05:57
altendky
altendky approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reserve the right to a refined opinion about where this belongs in the future... :] but this seems like a simple tidy. thanks.

@pmaslana pmaslana merged commit 3410597 into Chia-Network:main Jan 28, 2025
359 of 360 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardkiss @altendky @arvidn @pmaslana