Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use allow-dev-deps label to block merging and allow non-binary dependencies #19210

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
+33 −0
Draft

use allow-dev-deps label to block merging and allow non-binary dependencies #19210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0503d8
use `allow-dev-deps` label to block merging and allow non-binary depe…
altendky Jan 30, 2025
67a7d14
not here...
altendky Jan 30, 2025
5752448
check in both places
altendky Jan 30, 2025
6d945b2
use an output from the reflow to avoid checking the label directly
altendky Jan 30, 2025
57aaac6
fixup
altendky Jan 30, 2025
5f3248a
try just needs
altendky Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actions/install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ inputs:
runs:
using: "composite"
steps:
- name: Set up rust
if: ${{ contains( github.event.pull_request.labels.*.name, 'allow-dev-deps') }}
uses: dtolnay/rust-toolchain@stable

- name: Run install script (macOS, Ubuntu)
if: runner.os == 'macos' || runner.os == 'linux'
shell: bash
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/check_wheel_availability.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@ concurrency:
cancel-in-progress: true

jobs:
check-allow-dev-deps:
uses: ./.github/workflows/reflow-check-allow-dev-deps.yml

check_dependency_artifacts:
name: ${{ matrix.os.name }} ${{ matrix.arch.name }} ${{ matrix.python-version }}
needs: check-allow-dev-deps
runs-on: ${{ matrix.os.runs-on[matrix.arch.matrix] }}
strategy:
fail-fast: false
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/reflow-check-allow-dev-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: 🚨 Check allow-dev-deps label

on:
workflow_call:

concurrency:
# SHA is added to the end if on `main` to let all main workflows run
group: ${{ github.ref }}-${{ github.workflow }}-${{ github.event_name }}-${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/') || startsWith(github.ref, 'refs/heads/long_lived/')) && github.sha || '' }}
cancel-in-progress: true

jobs:
check-labels:
runs-on: ubuntu-latest
steps:
- name: check banned labels
uses: mheap/github-action-required-labels@v5
with:
mode: exactly
count: 0
labels: "allow-dev-deps"
5 changes: 5 additions & 0 deletions .github/workflows/test-install-scripts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ concurrency:
cancel-in-progress: true

jobs:
check-allow-dev-deps:
uses: ./.github/workflows/reflow-check-allow-dev-deps.yml

test_scripts:
name: Native ${{ matrix.os.emoji }} ${{ matrix.arch.emoji }} ${{ matrix.development.name }} - ${{ matrix.editable.name }}
needs: check-allow-dev-deps
runs-on: ${{ matrix.os.runs-on[matrix.arch.matrix] }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -134,6 +138,7 @@ jobs:

test_scripts_in_docker:
name: Docker ${{ matrix.distribution.name }} ${{ matrix.arch.name }}
if: ${{ !contains( github.event.pull_request.labels.*.name, 'allow-dev-deps') }}
runs-on: ${{ matrix.os.runs-on[matrix.arch.matrix] }}
container: ${{ matrix.distribution.url }}
strategy:
Expand Down
Loading