Merge pull request #29 from ChochaNaresh/Dev

- bug fixed #28
ChochaNaresh · Sep 4, 2023 · de4e3b2 · de4e3b2
2 parents d28f16c + 6fee9ea
commit de4e3b2
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,9 +1,9 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 plugins {
-    id("com.android.application").version("8.0.2").apply(false)
-    id("com.android.library").version("8.0.2").apply(false)
-    kotlin("android").version("1.8.22").apply(false)
-    id("io.gitlab.arturbosch.detekt").version("1.23.0").apply(false)
+    id("com.android.application").version("8.1.1").apply(false)
+    id("com.android.library").version("8.1.1").apply(false)
+    kotlin("android").version("1.9.0").apply(false)
+    id("io.gitlab.arturbosch.detekt").version("1.23.1").apply(false)
 }
 
 tasks.register("clean", Delete::class) {

diff --git a/filepickerlibrary/build.gradle.kts b/filepickerlibrary/build.gradle.kts
@@ -3,13 +3,14 @@ plugins {
     id("com.android.library")
     id("org.jetbrains.kotlin.android")
     id("kotlin-parcelize")
+    id("kotlin-kapt")
     id("io.gitlab.arturbosch.detekt")
     id("maven-publish")
 }
 
 android {
     namespace = "com.nareshchocha.filepickerlibrary"
-    compileSdk = 33
+    compileSdk = 34
 
     defaultConfig {
         minSdk = 21
@@ -123,7 +124,7 @@ publishing {
 }
 
 detekt {
-    toolVersion = "1.23.0"
-    config = files("config/detekt/detekt.yml")
+    toolVersion = "1.23.1"
+    config.setFrom("$projectDir/config/detekt/detekt.yml")
     buildUponDefaultConfig = true
 }
diff --git a/...c/main/java/com/nareshchocha/filepickerlibrary/ui/activitys/DocumentFilePickerActivity.kt b/...c/main/java/com/nareshchocha/filepickerlibrary/ui/activitys/DocumentFilePickerActivity.kt
@@ -213,7 +213,7 @@ internal class DocumentFilePickerActivity : AppCompatActivity() {
 
         private fun getPermission(): String {
             return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
-                Manifest.permission.READ_MEDIA_IMAGES
+                Manifest.permission.READ_MEDIA_VIDEO
             } else {
                 Manifest.permission.READ_EXTERNAL_STORAGE
             }

diff --git a/filepickerlibrary/src/main/java/com/nareshchocha/filepickerlibrary/utilities/FileUtils.kt b/filepickerlibrary/src/main/java/com/nareshchocha/filepickerlibrary/utilities/FileUtils.kt
@@ -100,7 +100,7 @@ internal object FileUtils {
     private fun Context.getDownloadsDocumentPath(uri: Uri): String? {
         val fileName = getFilePath(this, uri)
         if (fileName != null) {
-            Environment.getExternalStorageDirectory()
+            return Environment.getExternalStorageDirectory()
                 .toString() + "/Download/" + fileName
         }
         var id = DocumentsContract.getDocumentId(uri)

diff --git a/sample/build.gradle.kts b/sample/build.gradle.kts
@@ -5,14 +5,14 @@ plugins {
 
 android {
     namespace = "com.nareshchocha.filepicker"
-    compileSdk = 33
+    compileSdk = 34
 
     defaultConfig {
         applicationId = "com.nareshchocha.filepicker"
         minSdk = 21
-        targetSdk = 33
-        versionCode = 1
-        versionName = "1.0"
+        targetSdk = 34
+        versionCode = 2
+        versionName = "1.1"
 
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
         testInstrumentationRunnerArguments.putAll(

diff --git a/sample/src/main/java/com/nareshchocha/filepicker/MainActivity.kt b/sample/src/main/java/com/nareshchocha/filepicker/MainActivity.kt
@@ -83,6 +83,7 @@ class MainActivity : AppCompatActivity() {
                     .pickDocumentFileBuild(
                         DocumentFilePickerConfig(
                             allowMultiple = true,
+
                             mMimeTypes = listOf("application/pdf", "image/*"),
                         ),
                     ),