Skip to content

Commit

Permalink
Add ARM support to the executor (#249)
Browse files Browse the repository at this point in the history
* feat: ARM resource classes for executor

* Add tests to validate arm on executor

---------

Co-authored-by: Aleš Roubíček <ales@roubicek.name>
  • Loading branch information
marboledacci and rarous authored Jan 28, 2025
1 parent 53925de commit 6938c3a
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 1 deletion.
55 changes: 54 additions & 1 deletion .circleci/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,17 @@ jobs:
fi
integration-test-override-ci:
executor: node/default
parameters:
resource_class:
type: enum
default: medium
description: Configure the executor resource class
enum:
- medium
- arm.medium
executor:
name: node/default
resource_class: <<parameters.resource_class>>
steps:
- checkout
- node/install-packages:
Expand All @@ -164,8 +174,17 @@ jobs:
app-dir: "~/project/sample"
- run: cd ~/project/sample && npm run test
integration-test-pnpm:
parameters:
resource_class:
type: enum
default: medium
description: Configure the executor resource class
enum:
- medium
- arm.medium
executor:
name: node/default
resource_class: <<parameters.resource_class>>
steps:
- checkout
- run:
Expand All @@ -179,8 +198,17 @@ jobs:
app-dir: "~/project/sample"
- run: cd ~/project/sample && pnpm test
integration-test-yarn:
parameters:
resource_class:
type: enum
default: medium
description: Configure the executor resource class
enum:
- medium
- arm.medium
executor:
name: node/default
resource_class: <<parameters.resource_class>>
steps:
- checkout
- node/install-packages:
Expand All @@ -206,8 +234,17 @@ jobs:
integration-test-yarn-berry:
environment:
YARN_ENABLE_IMMUTABLE_INSTALLS: false
parameters:
resource_class:
type: enum
default: medium
description: Configure the executor resource class
enum:
- medium
- arm.medium
executor:
name: node/default
resource_class: <<parameters.resource_class>>
steps:
- checkout
- run: mv ~/project/sample/package-berry.json ~/project/sample/package.json
Expand Down Expand Up @@ -431,14 +468,30 @@ workflows:
rm ~/project/sample/package-lock.json
rm ~/project/sample/yarn.lock
- integration-test-override-ci:
matrix:
alias: integration-test-override-ci
parameters:
resource_class: [arm.medium, medium]
filters: *filters
- integration-test-pnpm:
matrix:
alias: integration-test-pnpm
parameters:
resource_class: [arm.medium, medium]
filters: *filters
- integration-test-override-ci-windows:
filters: *filters
- integration-test-yarn:
matrix:
alias: integration-test-yarn
parameters:
resource_class: [arm.medium, medium]
filters: *filters
- integration-test-yarn-berry:
matrix:
alias: integration-test-yarn-berry
parameters:
resource_class: [arm.medium, medium]
filters: *filters
- integration-test-yarn-berry-nocimg:
filters: *filters
Expand Down
4 changes: 4 additions & 0 deletions src/executors/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ parameters:
- xlarge
- 2xlarge
- 2xlarge+
- arm.medium
- arm.large
- arm.xlarge
- arm.2xlarge

docker:
- image: cimg/node:<<parameters.tag>>
Expand Down

0 comments on commit 6938c3a

Please sign in to comment.