dcnm_fabric: Fix for issue 343 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. module_utils/fabric/create.py Modify the payload for external fabric types to include EXT_FABRIC_TYPE key with value being the default value that the NDFC GUI uses to display the fabric type. 2. module_utils/fabric/fabric_types.py Add a mapping between external fabric types and the string NDFC uses when displaying the fabric type.
1. plugins/module_utils/fabric/create.py a. Change the method name _fixup_payload_ext_fabric_type() to _add_ext_fabric_type_to_payload() b. Add a log message in _add_ext_fabric_type_to_payload() when a payload has been modified.
1. module_utils.fabric/fabric_types.py Edit comment to mention that the private set is exposed via property external_fabric_types.
mikewiebe
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue found by Alessandro De Prato where Ansible-created external fabrics (e.g. ISN) are displayed with incorrect Fabric Type column value in the NDFC GUI on page:
NDFC -> Manage -> Fabrics
Details
For example, ISN fabric types are displayed with a column value of "Custom Fabric" but SHOULD be displayed with a column value of "Multi-Site External Network".
The reason is that the NDFC GUI adds the key
EXT_FABRIC_TYPEto the payload with the value (in the case of ISN) of "Multi-Site External Network".This only affects fabrics using the
External_Fabrictemplate.Testing
I've tested to verify the fix and have tested to verify that the fix does not change behavior for non-External fabric types.
Other
Have made the fix extensible, so that it can be applied to other fabric types that use the
External_Fabrictemplate, should we decide to add them.Resolves
#343