Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LH-83389): skip ftd update test #138

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat(LH-83389): skip ftd update test #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions client/device/cloudfmc/fmcappliance/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package fmcappliance

import (
"context"

"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/http"
"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/url"
)
Expand Down Expand Up @@ -33,6 +34,9 @@ type updateRequestBody struct {
}

func Update(ctx context.Context, client http.Client, updateInp UpdateInput) (*UpdateOutput, error) {

client.Logger.Println("updating fmc appliance")

updateUrl := url.UpdateFmcAppliance(client.BaseUrl(), updateInp.FmcApplianceUid)
updateBody := newUpdateRequestBodyBuilder().
QueueTriggerState(updateInp.QueueTriggerState).
Expand Down
4 changes: 4 additions & 0 deletions client/device/cloudfmc/retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@ package cloudfmc

import (
"context"

"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/http"
"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/retry"
"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/statemachine"
"github.com/CiscoDevnet/terraform-provider-cdo/go-client/model/statemachine/state"
)

func UntilStateDone(ctx context.Context, client http.Client, uid string) retry.Func {

client.Logger.Println("waiting for cdfmc to be done")

return func() (bool, error) {
fmcReadSpecificRes, err := ReadSpecific(ctx, client, NewReadSpecificInput(uid))
if err != nil {
Expand Down
2 changes: 2 additions & 0 deletions provider/internal/device/ftd/resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ var testResourceConfig_ReplaceGroupedLabels = acctest.MustParseTemplate(Resource

func TestAccFtdResource(t *testing.T) {

t.Skip("This test is flaky due to occasionally brief failure of fmceUpdateStateMachine, see LH-83416")

resource.Test(t, resource.TestCase{
PreCheck: acctest.PreCheckFunc(t),
ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
Expand Down
Loading