Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lh-86970): add Terraform resource to add an existing tenant to MSP portal using API token #153

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

siddhuwarrier
Copy link
Collaborator

@siddhuwarrier siddhuwarrier commented Dec 3, 2024

https://jira-eng-rtp3.cisco.com/jira/browse/LH-86970

Description

  1. Make the name field optional; require it only if api_token is not specified, and vice versa. This allows us to add existing tenants.
  2. Add an existing tenant as follows:
resource "cdo_msp_managed_tenant" "existing_tenant" {
  api_token = "existing-tenant-api-token"
}

TODO: unit and acceptance tests

@siddhuwarrier siddhuwarrier requested a review from talhazi December 3, 2024 12:22
Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small ones, LGTM

client/msp/tenants/add.go Outdated Show resolved Hide resolved
client/msp/tenants/add.go Outdated Show resolved Hide resolved
@siddhuwarrier siddhuwarrier merged commit 4364675 into main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants