Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ND version and site resources (DCNE-179) #6

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Add ND version and site resources (DCNE-179) #6

merged 13 commits into from
Nov 20, 2024

Conversation

sajagana
Copy link
Collaborator

No description provided.

samiib
samiib requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the CI is failing.
To get past that step I think you need to run chmod to change the scripts/gofmtcheck.sh permissions to 755.
I think something like git update-index --chmod=+x scripts/gofmtcheck.sh would do the trick.

samiib
samiib requested changes Aug 27, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@sajagana sajagana force-pushed the nd_base_code_new branch 2 times, most recently from 2dd2b3a to e908cc2 Compare August 27, 2024 15:45
shrsr
shrsr requested changes Aug 28, 2024
View reviewed changes
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
shrsr
shrsr requested changes Aug 29, 2024
View reviewed changes
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
@sajagana
[ignore] Change the ND_LOGIN_DOMAIN to ND_SITE_LOGIN_DOMAIN in the re…
d465c4e 
…source_nd_site.go and resource_nd_site_test.go file
@akinross akinross requested review from shrsr and samiib August 30, 2024 12:23
akinross
akinross previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib added the jira-sync Sync this issue to Jira label Sep 14, 2024
@github-actions github-actions bot changed the title Add ND version and site resources Add ND version and site resources (DCNE-179) Sep 14, 2024
gmicol
gmicol previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot requested changes Oct 3, 2024
View reviewed changes
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/resource_nd_site.go Outdated Show resolved Hide resolved
internal/provider/client.go Outdated Show resolved Hide resolved
internal/provider/client.go Outdated Show resolved Hide resolved
docs/resources/site.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@samiib samiib mentioned this pull request Oct 4, 2024
Merged
@sajagana sajagana dismissed stale reviews from anvitha-jain, gmicol, samiib, and shrsr via f9ec75d October 10, 2024 13:43
@sajagana sajagana requested a review from lhercot October 11, 2024 03:31
lhercot
lhercot requested changes Oct 29, 2024
View reviewed changes
docs/resources/site.md Outdated Show resolved Hide resolved
@sajagana sajagana requested a review from lhercot October 29, 2024 10:36
akinross
akinross approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit bc5bf8d into CiscoDevNet:main Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

Assignees
No one assigned
Labels
jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sajagana @lhercot @shrsr @akinross @anvitha-jain @samiib @gmicol