PR feedback

Author: kroenlein

src/citrine/_serialization/properties.py

@@ -264,17 +264,11 @@ def underlying_types(self):
 
     @property
     def serialized_types(self):
-        return float, int, str
+        return int, str
 
     def _deserialize(self, value: SerializedInteger) -> int:
         if isinstance(value, bool):
             raise TypeError('value must be a Number, not a boolean.')
-        elif isinstance(value, float):
-            cast = round(value)
-            if cast == value:
-                return cast
-            else:
-                raise ValueError(f'{value} cannot be cast to an integer.')
         else:
             return int(value)
 

src/citrine/gemd_queries/filter.py

@@ -48,17 +48,17 @@ class AllIntegerFilter(Serializable['AllIntegerFilter'], PropertyFilterType):
 
     Parameters
     ----------
-    lower: int
+    lower: float
         The lower bound on this filter range.
-    upper: int
+    upper: float
         The upper bound on this filter range.
     inclusive: bool
         Whether the lower & upper bounds are included in the range.
 
     """
 
-    lower = properties.Integer('lower')
-    upper = properties.Integer('upper')
+    lower = properties.Float('lower')
+    upper = properties.Float('upper')
     inclusive = properties.Optional(properties.Boolean, 'inclusive', default=True)
     typ = properties.String('type', default="all_integer_filter", deserializable=False)
 

tests/_serialization/_data.py

@@ -5,7 +5,6 @@
 
 VALID_SERIALIZATIONS = [
     (properties.Integer, 5, 5),
-    (properties.Integer, 5, 5.),  # Accept passing a float-representation of an int to the setter
     (properties.Float, 3.0, 3.0),
     (properties.Raw, 1234, 1234),
     (properties.String, 'foo', 'foo'),