Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve minor security issues. #945

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Resolve minor security issues. #945

merged 1 commit into from
Jun 20, 2024

Conversation

anoto-moniz
Copy link
Collaborator

Both were raised by GH's Dependabot. While we're not impacted by either, updating the impacted libraries takes no effort, so might as well.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz
Resolve minor security issues.
9d787a8 
Both were raised by GH's Dependabot. While we're not impacted by either,
updating the impacted libraries takes no effort, so might as well.
@anoto-moniz anoto-moniz mentioned this pull request Jun 13, 2024
Closed
StevenKauwe
StevenKauwe approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@StevenKauwe StevenKauwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoto-moniz anoto-moniz merged commit d7473d9 into main Jun 20, 2024
16 checks passed
@anoto-moniz anoto-moniz deleted the resolve-minor-security-issues branch June 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenKauwe StevenKauwe StevenKauwe approved these changes

@kroenlein kroenlein Awaiting requested review from kroenlein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoto-moniz @StevenKauwe