Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PNE-416] Use v4 listing endpoints. #947

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[PNE-416] Use v4 listing endpoints. #947

merged 2 commits into from
Jul 1, 2024

Conversation

anoto-moniz
Copy link
Collaborator

Predictors and design spaces have exposed v4 listing endpoints. The key difference is in the filtering. By default, they return all assets of the given type, and filters are specified as direct query arguments.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz anoto-moniz force-pushed the feature/pne-416-v4-listing-endpoints branch from 24caa0d to 4a084b7 Compare June 20, 2024 18:11
@anoto-moniz anoto-moniz marked this pull request as ready for review June 20, 2024 18:16
@anoto-moniz anoto-moniz requested a review from StevenKauwe June 27, 2024 14:47
StevenKauwe
StevenKauwe previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@StevenKauwe StevenKauwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@anoto-moniz
[PNE-416] Use v4 listing endpoints.
06d40cc 
Predictors and design spaces have exposed v4 listing endpoints. The key
difference is in the filtering. By default, they return all assets of
the given type, and filters are specified as direct query arguments.
@anoto-moniz
PR comments.
9f5cb7f
@anoto-moniz anoto-moniz force-pushed the feature/pne-416-v4-listing-endpoints branch from 0fe2a8d to 9f5cb7f Compare June 28, 2024 13:41
@anoto-moniz anoto-moniz requested a review from StevenKauwe June 28, 2024 13:43
StevenKauwe
StevenKauwe approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@StevenKauwe StevenKauwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoto-moniz anoto-moniz merged commit a81506f into main Jul 1, 2024
16 checks passed
@anoto-moniz anoto-moniz deleted the feature/pne-416-v4-listing-endpoints branch July 1, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenKauwe StevenKauwe StevenKauwe approved these changes

@kroenlein kroenlein Awaiting requested review from kroenlein

@jamie-heller jamie-heller Awaiting requested review from jamie-heller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoto-moniz @StevenKauwe