Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Manager Documentation Update #951
Data Manager Documentation Update #951
Changes from 10 commits
c7dae3c
94a0432
2a1deb4
a447f08
9642946
9ffa18a
4b9b811
49ae83c
076f7b4
10eea2f
47c2949
5e8c23c
5ba2c72
0f946fc
829fec0
64efd1b
cf0ba47
eb78af0
2129368
cafe381
a557a5f
4a89b1b
64e9b29
823fbbf
dd4cb13
b428239
19a4515
b4af156
902fdac
8ca0744
767f9f6
c1aff0f
0035475
d760980
934d8ae
a7ea178
b5de4db
10acd1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should never have been able to do this along a project-based route for GEMD objects. It always required a dataset (maybe delete was an exception? Definitely true for update). In the past, that returned a simple error. @pacdaemon and @anoto-moniz might have accidentally made something broken when they added their deprecations there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the actions were just read-only if only the project was reference. E.g. .list() or .get() would work, but not register or update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed, though I used "update" as an example since we use "delete before. Still not sure about whether or not we allow update or other things from the team-level endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kroenlein To clarify, is there something in the SDK code that makes you think something's broken? Or are you just saying this line of the documentation was wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it locally and got a giant splat of exception handling that did not indicate the real problem. However, I then ran the same code with v3.2.11 and got the same error, so if we have more elegant handling in the past, that was last in a previous release.
This file was deleted.