Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address DW with branch root ID and version. #965

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Address DW with branch root ID and version. #965

merged 1 commit into from
Sep 20, 2024

Conversation

anoto-moniz
Copy link
Collaborator

Now that the design workflow APIs support branch root ID and version explicitly, the SDK should use them. This cuts down on excess requests, resulting in much faster executions.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz
Address DW with branch root ID and version.
ede810b 
Now that the design workflow APIs support branch root ID and version
explicitly, the SDK should use them. This cuts down on excess requests,
resulting in much faster executions.
@anoto-moniz anoto-moniz marked this pull request as ready for review September 20, 2024 16:14
@anoto-moniz anoto-moniz requested a review from a team as a code owner September 20, 2024 16:14
kroenlein
kroenlein approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anoto-moniz anoto-moniz merged commit e5355f0 into main Sep 20, 2024
16 checks passed
@anoto-moniz anoto-moniz deleted the use-dw-branch-root-and-version branch September 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroenlein kroenlein kroenlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoto-moniz @kroenlein