Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNE-6610] Expose more candidate attributes. #987

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

anoto-moniz
Copy link
Collaborator

Expose the pinned metadata, hidden attribubte, and name of each candidate as read-only properties.

Citrine Python PR

Description

Please briefly explain the goal of the changes/this PR.
The reviewer should be able to understand why the change is being made by reading this description
and its links (e.g. JIRA tickets).

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

Expose the pinned metadata, hidden attribubte, and name of each candidate
as read-only properties.
@anoto-moniz anoto-moniz marked this pull request as ready for review February 14, 2025 17:37
@anoto-moniz anoto-moniz requested a review from a team as a code owner February 14, 2025 17:37
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though it'd be nice to see a FactoryBoy fixture being added for DesignCandidate in the context of adding new fields.

@anoto-moniz anoto-moniz merged commit 2e98401 into main Feb 18, 2025
17 checks passed
@anoto-moniz anoto-moniz deleted the feature/pne-6610-expose-candidate-attributes branch February 18, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants