Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PNE-6674] Expose candidate comments. #988

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[PNE-6674] Expose candidate comments. #988

merged 1 commit into from
Feb 24, 2025

Conversation

anoto-moniz
Copy link
Collaborator

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz anoto-moniz force-pushed the feature/pne-6674-candidate-comments branch from 33cf139 to f94b326 Compare February 20, 2025 20:03
@anoto-moniz anoto-moniz marked this pull request as ready for review February 21, 2025 15:18
@anoto-moniz anoto-moniz requested a review from a team as a code owner February 21, 2025 15:18
kroenlein
kroenlein approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoto-moniz anoto-moniz merged commit e1090a5 into main Feb 24, 2025
17 checks passed
@anoto-moniz anoto-moniz deleted the feature/pne-6674-candidate-comments branch February 24, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroenlein kroenlein kroenlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoto-moniz @kroenlein